Patches item #1956216, was opened at 2008-05-02 18:19 Message generated for change (Comment added) made by bogdan_iancu You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=743022&aid=1956216&group_id=139143
Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: modules Group: ver devel Status: Open >Resolution: Accepted Priority: 5 Private: No Submitted By: Ovidiu Sas (osas) Assigned to: Bogdan-Andrei Iancu (bogdan_iancu) Summary: dialog: new mi commands: dlg_show/dlg_show_ctx Initial Comment: The following patch is adding two new mi commands to the dialog module: dlg_show <call-id> [<from_tag>] dlg_show_ctx <call-id> [<from_tag>] The output of the two commands is the same as the output of dlg_list/dlg_list_ctx, but instead of listing all the dialogs, only the dialogs matched by the call-id and from_tag (if given) will be listed. Regards, Ovidiu Sas ---------------------------------------------------------------------- >Comment By: Bogdan-Andrei Iancu (bogdan_iancu) Date: 2008-05-07 22:42 Message: Logged In: YES user_id=1275325 Originator: NO Hi Ovidiu, You are right - let's keep the command simple and to return only one dialog based on callid and fromtag - What I overlook was that a search based on callid only not only that will take longer, but will kill the hash table by keeping it locked ... I will review the patch and upload it asap. Regarding the improved logs - ANY TIME :D Regards, Bogdan ---------------------------------------------------------------------- Comment By: Ovidiu Sas (osas) Date: 2008-05-07 19:32 Message: Logged In: YES user_id=1395524 Originator: YES Hello Bogdan, I see what you are trying to accomplish now :) My initial implementation for queries with clid only was for bogus clients that don't send a from tag. Iterating through the whole table for clid only queries versus iterating through an single entry for clid/from_tag queries is ok. Most of the time we will have a from_tag, so we will know the right entry. I wouldn't like to iterate through the whole table for each query, especially for tables with thousands of dialogs :) Next on my TODO list (for the dialog module) is to enhance the dialog error logs with pertinent informations for debugging (CLID/from_tag). Regards, Ovidiu Sas ---------------------------------------------------------------------- Comment By: Bogdan-Andrei Iancu (bogdan_iancu) Date: 2008-05-07 19:10 Message: Logged In: YES user_id=1275325 Originator: NO Ovidiu, The missing fromtag in the command doesn't mean we need to change the hashing - it means just that the dialog search (in this case) will be a bit slower (as we need to iterate the whole table based on callid). I noticed that in your proposal, the framtag may be missing also. Regards, Bogdan ---------------------------------------------------------------------- Comment By: Ovidiu Sas (osas) Date: 2008-05-07 18:59 Message: Logged In: YES user_id=1395524 Originator: YES Hello Bogdan, Right now, the hash entry (h_entry) for new dialogs is computed based on clid and from_tag. If we change it to be computed based on clid only, then yes, we can get rid of the from_tag and take the "clid only" aproach (i.e. no from tag for the mi query). Regards, Ovidiu Sas ---------------------------------------------------------------------- Comment By: Bogdan-Andrei Iancu (bogdan_iancu) Date: 2008-05-07 18:39 Message: Logged In: YES user_id=1275325 Originator: NO Hi Ovidiu, Thanks for the patch - it is something useful indeed. Couple of questions - do you think passing fromtag will help in matching the dialog? more or less the dialog id should be enough especially that is relevant only for ongoing call at a moment? I'm asking this because I was thinking of passing only callid as parameter - this will allow to pass a list of callids if you want to get multiple dialogs anyhow I will review it during this week. Regards, Bogdan ---------------------------------------------------------------------- Comment By: Ovidiu Sas (osas) Date: 2008-05-06 16:40 Message: Logged In: YES user_id=1395524 Originator: YES If there are no objections, I will push this in by the end of the week. Regards, Ovidiu Sas ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=743022&aid=1956216&group_id=139143 _______________________________________________ Devel mailing list Devel@lists.openser.org http://lists.openser.org/cgi-bin/mailman/listinfo/devel
