Patches item #1927279, was opened at 2008-03-27 19:02 Message generated for change (Comment added) made by miconda You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=743022&aid=1927279&group_id=139143
Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: modules Group: ver 1.3.x Status: Open Resolution: None Priority: 5 Private: No Submitted By: Herman Sheremetyev (has207) Assigned to: Daniel-Constantin Mierla (miconda) Summary: fix various corruption and leaks in dbtext Initial Comment: Ensure table names are properly \0 terminated and fix dbt_db_get_table() to stop using dbt_db_del_table() which was forcing it to release and re-establish the lock (race condition?). Instead the dbt_db_del_table() functionality is implemented inside dbt_db_get_table() such that you don't have to traverse the entire list all over again since at that point we already know which item from the list needs to be removed. Also, and most importantly, fix up the linked list maintenance code that keeps the tables in memory. This was subtly broken and causing all sorts of fun in db_mode=1. ---------------------------------------------------------------------- >Comment By: Daniel-Constantin Mierla (miconda) Date: 2008-05-18 11:15 Message: Logged In: YES user_id=1246013 Originator: NO Backports applied before 1.3.2. Re-open of new issues are found. ---------------------------------------------------------------------- Comment By: Daniel-Constantin Mierla (miconda) Date: 2008-05-03 22:54 Message: Logged In: YES user_id=1246013 Originator: NO Hi, I have applied a different patch in the SVN trunk for the race. There is something I didn't actually understand for the linked list and therefore not applied so far. You are testing for the duplicate of the table and break the list if you find. That should not happen, if happens the fix should be somewhere else and not let a table be many times in the memory. Could you confirm that it is the case, I investigated and couldn't find yet where a table can be added second time? Please test the trunk and see if the race is fixed. I will backport then to the 1.3 Daniel ---------------------------------------------------------------------- Comment By: Daniel-Constantin Mierla (miconda) Date: 2008-04-17 14:42 Message: Logged In: YES user_id=1246013 Originator: NO Thanks. I will review and commit. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=743022&aid=1927279&group_id=139143 _______________________________________________ Devel mailing list Devel@lists.openser.org http://lists.openser.org/cgi-bin/mailman/listinfo/devel
