Bugs item #3041667, was opened at 2010-08-09 01:12 Message generated for change (Comment added) made by bogdan_iancu You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=1086410&aid=3041667&group_id=232389
Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: core Group: trunk >Status: Closed >Resolution: Fixed Priority: 5 Private: No Submitted By: Stanislaw Pitucha (viraptor) >Assigned to: Bogdan-Andrei Iancu (bogdan_iancu) Summary: Type of db tail Initial Comment: This is not a serious bug really, but I noticed that `db_con_t.tail` is a long, but in every case I've seen it contains a pointer cast to long instead. Just to ensure portability, it could be a pointer. It could also explain the field a bit better. Current comment says "Variable length tail, database module specific", which (because of the name) I'd normally expect to be expanding, trailing array (char tail[0]). "Pointer to implementation-specific database state" could be more useful there. ---------------------------------------------------------------------- >Comment By: Bogdan-Andrei Iancu (bogdan_iancu) Date: 2010-09-21 13:50 Message: Changing it from long to pointer does not bring or improve anything. LONG and POINTER are the same as size on all platform. So, I see no reason to start changing in all the DB modules if there is no gain ...only if someone comes the done patch for that ;) For the comment part, I agree. Regards, Bogdan ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=1086410&aid=3041667&group_id=232389 _______________________________________________ Devel mailing list [email protected] http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
