Hi Olivier,

You are right, srandom is not used right there.
However, we want to take out that part from there, not use srand anymore and extend another mechanism for getting unique values that is now used for top hiding, to other scenarios also. Now for top hiding the from_tag is computed from 4 values taken from the message - callid, fromtag, ruri and via branch.
I will implement this and take out the random from there next week.

Thanks and regards,

--
Anca Vamanu
OpenSIPS Developer




On 02/11/2011 03:55 PM, Olivier Détour wrote:
Here is my patch.
Why: srand has to be initiate with a different value by process.
In the previous version, srand called get_uticks with concurrency
access, and rand value will be the same.

On Fri, Feb 11, 2011 at 2:21 PM, SourceForge.net
<nore...@sourceforge.net>  wrote:
Bugs item #3178281, was opened at 2011-02-11 13:21
Message generated for change (Tracker Item Submitted) made by nobody
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=1086410&aid=3178281&group_id=232389

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: modules
Group: 1.6.x
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Nobody/Anonymous (nobody)
Assigned to: Nobody/Anonymous (nobody)
Summary: Srand in b2b_entities

Initial Comment:
Hi,
The use of srand is wrong in generation of random value in the second part of 
callid.
srand have to be called one time for init, after call rand to get a random 
value.

Regards,



_______________________________________________
Devel mailing list
Devel@lists.opensips.org
http://lists.opensips.org/cgi-bin/mailman/listinfo/devel

Reply via email to