Just as an update, this second report was actually a false alarm.

Regards,
Bogdan

On 05/15/2012 06:33 PM, Ovidiu Sas wrote:
Hello Bogdan,

During the initial do_routing, the AVPs are set properly (index 0
holding AVPs with the higher priority).
However, during next_routing, the AVPs are updated, but it seems that
"gw_attrs_avp" was left out (it still points to the old value on index
0).

-ovidiu

On Tue, May 15, 2012 at 10:39 AM, Bogdan-Andrei Iancu
<bog...@opensips.org>  wrote:
Hi Ovidiu,

Found and fixed the issues you mentioned. I fix is on trunk only (see rev
9019) - could you please also test, so that I can do a backport to 1.8 also
?

Thanks and regards,
Bogdan


On 05/11/2012 05:45 PM, Ovidiu Sas wrote:
On Fri, May 11, 2012 at 10:37 AM, Bogdan-Andrei Iancu
<bog...@opensips.org>    wrote:
Hi Ovidiu,


On 05/11/2012 01:44 AM, Ovidiu Sas wrote:
When populating the drouting AVPs while calling do_routing(), the AVPs
are not populated in order (like it is for dispatcher).
Which AVPs ? for next destination ?
Maybe I wasn't clear enough here.
The gw_id_avp, gw_attrs_av, carrier_id_avp are pushed into an avp
array.  The array is in reverse order (I mean when you print out the
avp without an index, is index 0, and it is not pointing to the
current gw/carrier that is used - the last element into the avp is
pointing to the right gw/carrier).  I was comparing this with the
dispatcher behaviour where the avp are in the right order and even in
failure route, you have proper values in index 0 of each avp.  This is
handy in taking routing decisions.


Also, the AVPs are not consumed during a transaction failover to
reflect the current route, carrier and gateway that is used.
well, when doing next_route(), the used AVPs should be trashed, a new
ones
available, corresponding to new routing.
The AVPs are an array and are not updated on next_route().


Is this something that was overlooked?
it may be a bug....

Regards,
Bogdan

It would be nice to have up to date values in AVPs.

Regards,
Ovidiu Sas

--
Bogdan-Andrei Iancu
OpenSIPS Founder and Developer
http://www.opensips-solutions.com


--
Bogdan-Andrei Iancu
OpenSIPS Founder and Developer
http://www.opensips-solutions.com





--
Bogdan-Andrei Iancu
OpenSIPS Founder and Developer
http://www.opensips-solutions.com


_______________________________________________
Devel mailing list
Devel@lists.opensips.org
http://lists.opensips.org/cgi-bin/mailman/listinfo/devel

Reply via email to