Hi Michael,

We are not keen to, but usually bugs + patches are reported via the SF tracker - just to be able to manage them. Otherwise there is a risk to get lost in the tons of emails :).

I do not see any issues with your fix and I will upload it on SVN.

Thanks and Best regards,

Bogdan-Andrei Iancu
OpenSIPS Founder and Developer
http://www.opensips-solutions.com


On 02/03/2013 07:58 PM, Michael Schloh von Bennewitz wrote:
Hello list,

On Sun., Jan. 27, 2013, Michael Schloh von Bennewitz wrote:
Before I made this change to sctp_server.c line 72 (in SVN trunk)
starting OpenSIPS with the 'fork' option configured failed and wrote
the following error to the log:

ERROR:core:sctp_server_init: socket: Protocol not supported [120]

--- sctp_server.c.orig  2013-01-27 19:35:29.459074161 +0100
+++ sctp_server.c       2013-01-27 19:48:43.304765833 +0100
@@ -69,7 +69,7 @@
                goto error;
        }
        
-       sock_info->socket = socket(AF2PF(addr->s.sa_family), SOCK_SEQPACKET, 0);
+       sock_info->socket = socket(AF2PF(addr->s.sa_family), SOCK_SEQPACKET, 
IPPROTO_SCTP);
        if (sock_info->socket==-1){
                LM_ERR("socket: %s [%d]\n", strerror(errno), errno);
                goto error;

Just a little confused about why this correction is being ignored.
Is it intentional, or due to testing inability? Should I make a
formal bug report, or is there some other reason? I can imagine
questions about the change, but have not seen any on the list.

Regards,
Michael

_______________________________________________
Devel mailing list
Devel@lists.opensips.org
http://lists.opensips.org/cgi-bin/mailman/listinfo/devel


_______________________________________________
Devel mailing list
Devel@lists.opensips.org
http://lists.opensips.org/cgi-bin/mailman/listinfo/devel

Reply via email to