Branch: refs/heads/master
Home: https://github.com/OpenSIPS/opensips
Commit: 0dc968169a8d61cb6f9dea6143edb6dcf738e0d6
https://github.com/OpenSIPS/opensips/commit/0dc968169a8d61cb6f9dea6143edb6dcf738e0d6
Author: Liviu Chircu <[email protected]>
Date: 2020-02-24 (Mon, 24 Feb 2020)
Changed paths:
M modules/dialog/dlg_db_handler.c
M modules/dialog/dlg_handlers.c
M modules/dialog/dlg_replication.c
Log Message:
-----------
dialog: Fix some locking corner-cases
* Re-INVITE pinging: synchronize writers and readers for the
dlg->legs->adv_contact string, as well as the entire dlg->legs
struct. Example subtle race conditions:
1. setting $DLG_timeout after t_relay() (read op) vs.
concurrently processing a 200 OK (write op)
2. calling MI "dlg_push_var" after t_relay() (read op) vs.
concurrently processing a 200 OK (write op)
3. in parallel forking, dlg_onreq_out() (read op) vs.
concurrently processing 200 OK for prev. branch (write op)
* DB load: to be 100% accurate, do not use ref_unsafe(), as we
don't hold the lock -- use the safe version instead!
_______________________________________________
Devel mailing list
[email protected]
http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
