It is not incorrect at all.
"the pkg_pretend phase can be used to do sanity checks before the main
phase function sequence is run", which exactly is what the samba
ebuild is doing, checking there is a sane GCC version. Now, It should
be wrapped in a:
if [[ ${MERGE_TYPE} != binary ]]
But that is the correct phase regardless, see for instance the kdelibs ebuild.
I wish you wouldn't always take such a dismissive tone sometimes.
On 1 December 2011 20:01, Fabio Erculiani <lx...@sabayon.org> wrote:
> pkg_pretend is incorrect as well
> http://devmanual.gentoo.org/ebuild-writing/functions/pkg_pretend/index.html
>
> --
> Fabio Erculiani
>
--
Ian Whyman
v00d00.net
