fre, 04 03 2005 kl. 13:23 +0300, skrev Paul Bagyenda:
> - the move you suggested, of list_destroy(lto,NULL) in mmsfromemail.c 
> is potentially dodgy since that variable is reset in the meantime. So 
> in some circumstances, a leak could have resulted. I have made some 
> changes around that.

Fair enough. However, if it is not moved, the call to mms_log hangs
because it waits for a lock on the list, so we have to fix that some
other way.

> - In mmsproxy.c, the change you had suggested on when to send DLR to 
> the sender pointed out a bug, but potentially introduced another: 
> According to spec, we must send DLR if the recipient inserts the 
> X-Mms-Report-Allowed header with a value of "Yes" *or* if they do not 
> insert the header (i.e. default is "Yes"). (Of course we must also only 
> send DLR if the sender asked for it.) Introduced what I hope is the 
> right logic.

Super!

-- 
SÃren Hansen <[EMAIL PROTECTED]>

Attachment: smime.p7s
Description: S/MIME cryptographic signature

_______________________________________________
Devel mailing list
[email protected]
http://mbuni.org/mailman/listinfo/devel_mbuni.org

Reply via email to