Module: monitoring-plugins
Branch: master
Commit: 3f9b22ab16b5a9b74d62d7fff9b6bf3a51ed93f7
Author: Aksel Sjögren <asjog...@itrsgroup.com>
Committer: Sven Nierlein <s...@nierlein.org>
Date: Mon Nov 15 14:29:51 2021 +0100
URL:
https://www.monitoring-plugins.org/repositories/monitoring-plugins/commit/?id=3f9b22a
check_icmp: Fix pkt perfdata in check_host mode
Add missing "warn" threshold field in "pkt" perfdata output.
Perfdata should be interpreted as;
'label'=value[UOM];[warn];[crit];[min];[max]
With one field missing, the hardcoded min value '0' ended up in the
"crit" field, making applications interpreting the perfdata thining that
critical threshold is always exceeded.
Signed-off-by: Aksel Sjögren <asjog...@itrsgroup.com>
---
plugins-root/check_icmp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/plugins-root/check_icmp.c b/plugins-root/check_icmp.c
index 31eb4c6..519b93c 100644
--- a/plugins-root/check_icmp.c
+++ b/plugins-root/check_icmp.c
@@ -921,7 +921,7 @@ wait_for_reply(int sock, u_int t)
/* if we're in hostcheck mode, exit with limited printouts */
if(mode == MODE_HOSTCHECK) {
printf("OK - %s responds to ICMP. Packet %u, rta
%0.3fms|"
- "pkt=%u;;0;%u rta=%0.3f;%0.3f;%0.3f;;\n",
+ "pkt=%u;;;0;%u rta=%0.3f;%0.3f;%0.3f;;\n",
host->name, icmp_recv, (float)tdiff / 1000,
icmp_recv, packets, (float)tdiff / 1000,
(float)warn.rta / 1000, (float)crit.rta / 1000);
