On 1/27/19, Eric S. Raymond via devel <devel@ntpsec.org> wrote: > I expect this module to be used by ntpd and a small ntske server > daemon. Because I don't believe incremental code is coing to be an > issue in any of our deployments, I've chosen an organization that > minimizes the exposed API and keeps both client and server NTS code in > one file for maintainability, rather than one that tries to partition > it so that neither deployment sees code unique to the other. > > Ueful comments will be those pointing out if this interface fails to > capture any transaction steps described in the RFC, or that the > implied data flow to/from the rest of ntpd needs to change. It's not > time to argue about policy or implementation details in the code just > yet; for now that conversation should continue as edits to nts.adoc. > > While the rest of you look at this and respond, I will be doing > the necessary changes to the configuration parser so it can supply the > parameters needed by the module. > -- > <a href="http://www.catb.org/~esr/">Eric S. Raymond</a>
Deliberate? misspacing in ntpd/wscript (tab), some typos in ntpd/nts.c and no apparent handling of startup and shutdown events. It looks good to me. Oh, useful I am not so good at that. _______________________________________________ devel mailing list devel@ntpsec.org http://lists.ntpsec.org/mailman/listinfo/devel