Dev, Vasu wrote:
>>>
>>> Also for the fc_fcp_timeout->fc_timeout_error path, if the seq_ptr is
>>> set we never call exch_done to clean up the response handler.
> 
> Abort handling in fc_exch.c will complete the exchange in this case but

Oh yeah, Vasu what are you talking about here?  I was not worried about 
the exhange getting cleaned up. I was worried about the ep->resp calling 
into the fc_fcp.c with a freed fsp. There was nothing in the existing 
code to prevent that right? You were just talking about the ep getting 
freed here and not leaking, and not the race (race will be fixed with 
all the other stuff we talked about)?

> I do see other issues along this as you also have described below.
> 
>>> fc_io_compl then does the release on the fsp from the initial allocation
>>> so if we ever do get a response the ep->resp is going to be accessing a
>>> freed (or possible reallocated to some other command) fsp.
>>>
_______________________________________________
devel mailing list
[email protected]
http://www.open-fcoe.org/mailman/listinfo/devel

Reply via email to