There are a few instances where the rport is checking
if the rport transitioning through the rport state
machine is the NS rport. It then sends an event to
the lport. The rport shouldn't be events to the lport
in so many places. This patch removes most of the
unnecessary calls.
There are still problems with fc_rport_recv_prli_req.
Signed-off-by: Robert Love <[EMAIL PROTECTED]>
---
drivers/scsi/libfc/fc_rport.c | 18 ------------------
1 files changed, 0 insertions(+), 18 deletions(-)
diff --git a/drivers/scsi/libfc/fc_rport.c b/drivers/scsi/libfc/fc_rport.c
index 0d4550f..71238d2 100644
--- a/drivers/scsi/libfc/fc_rport.c
+++ b/drivers/scsi/libfc/fc_rport.c
@@ -371,20 +371,9 @@ static void fc_rport_reject(struct fc_rport *rport)
}
break;
case RPORT_ST_RTV:
- /*
- * XXX- Does this case mean that the RTV failed, but
- * we enter READY anyway?
- */
fc_rport_state_enter(rport, RPORT_ST_READY);
if (fc_rp_debug)
FC_DBG("remote %6x ready", rport->port_id);
-
- if (rport->port_id >= FC_FID_DOM_MGR) {
- fc_lport_lock(lp);
- del_timer(&lp->state_timer);
- lp->tt.lport_event_callback(lp, rport,
LPORT_EV_RPORT_SUCCESS);
- fc_lport_unlock(lp);
- }
break;
case RPORT_ST_LOGO:
fc_rport_state_enter(rport, RPORT_ST_INIT);
@@ -765,7 +754,6 @@ static void fc_rport_rtv_resp(struct fc_seq *sp, struct
fc_frame *fp,
{
struct fc_rport *rport = rp_arg;
struct fc_rport_libfc_priv *rp = rport->dd_data;
- struct fc_lport *lp = rp->local_port;
u8 op;
if (IS_ERR(fp)) {
@@ -800,12 +788,6 @@ static void fc_rport_rtv_resp(struct fc_seq *sp, struct
fc_frame *fp,
if (fc_rp_debug)
FC_DBG("remote %6x ready", rport->port_id);
- if (rport->port_id >= FC_FID_DOM_MGR) {
- fc_lport_lock(lp);
- del_timer(&lp->state_timer);
- lp->tt.lport_event_callback(lp, rport, LPORT_EV_RPORT_SUCCESS);
- fc_lport_unlock(lp);
- }
fc_frame_free(fp);
}
_______________________________________________
devel mailing list
[email protected]
http://www.open-fcoe.org/mailman/listinfo/devel
