> -----Original Message-----
> From: Robert Love [mailto:[email protected]] 
> Sent: Friday, March 27, 2009 1:31 PM
> To: Abhijeet Arvind Joglekar (abjoglek)
> Cc: [email protected]
> Subject: Re: [Open-FCoE] [PATCH 4/6] libfc: During fabric 
> logoff, flush the rport Q after logging off dns port
> 
> On Fri, 2009-03-27 at 13:27 -0700, Robert Love wrote:
> > On Mon, 2009-03-23 at 11:39 -0700, Abhijeet Joglekar wrote:
> > > Signed-off-by: Abhijeet Joglekar <[email protected]>
> > 
> > We should have an actual commit message even if the patch title is 
> > descriptive enough. I'll just duplicate the title as the commit 
> > message before I apply this patch unless you have something 
> specific 
> > you want to see as the commit message.
> > 
> Actually, I'm not sure the title alone justifies the change. 
> The reason you're submitting this patch is because you want 
> to generate the rport Q event (from the logoff) before 
> flushing the Q, right?
> 
> I'll put something like that in the commit message, unless 
> you disagree.

Yes, that's right, please add the message in the commit. 

Sorry, I will document the "why" and not just the "what" in subsequent
patches.

-- abhijeet
_______________________________________________
devel mailing list
[email protected]
http://www.open-fcoe.org/mailman/listinfo/devel

Reply via email to