>-----Original Message----- >From: Joe Eykholt [mailto:[email protected]] >Sent: Friday, May 08, 2009 11:01 AM >To: Ma, Steve >Cc: [email protected] >Subject: Re: [Open-FCoE] [PATCH] libhbalinux: PCI-based network HBA is a >network device > >Ma, Steve wrote: >> >>> -----Original Message----- >>> From: Joe Eykholt [mailto:[email protected]] >>> Sent: Friday, May 08, 2009 10:30 AM >>> To: Ma, Steve >>> Cc: [email protected] >>> Subject: Re: [Open-FCoE] [PATCH] libhbalinux: PCI-based network HBA is a >>> network device >>> >>> Steve Ma wrote: >>>> A PCI-based network HBA shoud be handled as a network device. >>>> It was incorrectly handled as non-network PCI device. >>> >>> Our fnic is not a network device. Clients of libfc.ko do not have to >>> be clients of fcoe.ko, and should not have to be network devices or even >>> PCI devices. >>> >> Is your fnic a PCI device? > >Yes. My point was that shouldn't be necessary for libfc clients. > >Some network devices aren't PCI, although I can't imagine running >FCoE over an ISA, USB or firewire NIC. Let's forget that issue. >My main problem was that fnic doesn't have a netdev interface. > >Will your fix will work for non-net PCI devices? It looks like it might, >and I can try it sometime. > > Cheers, > Joe > Yes, it will work for non-net pci devices. For non-pci, non-net devices, the current code does not support.
>>>> Signed-off-by: Steve Ma <[email protected]> >>>> --- >>>> >>>> lport.c | 2 +- >>>> 1 files changed, 1 insertions(+), 1 deletions(-) >>>> >>>> diff --git a/lport.c b/lport.c >>>> index 80de20f..3cd0304 100644 >>>> --- a/lport.c >>>> +++ b/lport.c >>>> @@ -177,7 +177,7 @@ sysfs_scan(struct dirent *dp, void *arg) >>>> goto skip; >>>> buf[i] = '\0'; >>>> >>>> - if (strstr(buf, "devices/pci")) { >>>> + if (strstr(buf, "devices/pci") && !strstr(buf, "/net/")) { >>> >>>> snprintf(hba_dir, sizeof(hba_dir), "%s/device/..", host_dir); >>>> } else { >>>> /* assume a net device */ >>>> >>>> _______________________________________________ >>>> devel mailing list >>>> [email protected] >>>> http://www.open-fcoe.org/mailman/listinfo/devel >> _______________________________________________ devel mailing list [email protected] http://www.open-fcoe.org/mailman/listinfo/devel
