Dne čtvrtek 07 května 2009 19:36:18 Joe Eykholt napsal(a): > The patch mail seems to be formatted by something that padded lines and > split some. Some lines are longer than 80 chars. I can't apply it so > it's hard to see exactly what it does. It seems the coding style varies > from the one used in the rest of the code, which should be Linux kernel > style, more or less. Indentation by tabs. Yes, the mailing list seems to automatically reformat it somehow. No problem to rewrite it, so the reformating won't destroy the code like this. For now, the patch is also in bugzilla - I put it there prior to posting it to mailing list.
> These are a lot of issues to change, and they could be done in separate > patches, and not all are urgent. Also, others might not agree, since > these would change the man page, but the changes I suggest are in the > spirit of how getopt was designed to be used. I'd like to know opinion of other developers. I agree with Joe and I'm willing to do the code reconstruction if others are in agreement too and desired behaviour is specified. > Style: there should be spaces after the comma and around the +. Sorry for this, I usually do that, I don't know why I didn't do it this time. > I'm not sure why this is having to look for - and =, getopt should > do that for you with optarg. I don't think this is the way to do it. I tried it that way, but optarg is filled only when option argument is mandatory, which is not the case when options -i or -t are used (according to man pages and also the original source code) -- Jan _______________________________________________ devel mailing list [email protected] http://www.open-fcoe.org/mailman/listinfo/devel
