On Wed, May 20, 2009 at 06:28:22PM -0700, Joe Eykholt wrote:
> For FIP, there should be just one handler for all the lports on the fabric.
> Most of the FIP frames are for the main lport and its link state. Link
> state of course affects all the lports.
>
> The demux for FLOGI/FDISC responses should be in libfcoe. That'll
> work better for fnic, which also needs to do the same thing.
I had some thoughts related to this. I think we can use the elsct_send
hook in libfcoe to handle FIP encapsulated ELS and take those checks out
of the SCSI FCP transmit fast path. It also makes it easier to share
between fcoe and fnic.
The receive side isn't as critical, as they're already filtered out by the
FIP ethertype, but it might be cleaner to use an FCoE specific exchange
response handler to do the address handling for FLOGI and FDISC.
I'll see what I can come up with.
> For FCoE, I think we need to key on the exchange ID, using a shared exchange
> manager for all the NPIV sessions, or perhaps hash on the D_ID, but I prefer
> the shared EM approach.
That would be fairly easy, as long as there's not a concern of over
sharing the X_ID space. It's probably OK, there shouldn't be an
expectation of the number of outstanding exchanges scaling with NPIV.
> I'm really happy to see these patches. I haven't gone all the way through
> them yet.
> I'll have more comments tomorrow or so.
Thanks Joe.
Chris
_______________________________________________
devel mailing list
[email protected]
http://www.open-fcoe.org/mailman/listinfo/devel
