On Thu, Jul 09, 2009 at 11:34:45AM -0700, Joe Eykholt wrote: > Chris Leech wrote: > > There is only one FIP state per net_device, so the FIP controller needs to > > be > > moved from the per-SCSI-host fcoe_port to the per-net_device fcoe_interface > > structure. > > > > Also changed fcoe_from_ctlr() from a preprocessor macro to an inline > > function > > around container_of(), to get type checking on the use of the return value. > > That change is OK with me, but container_of() already casts the result > to the appropriate type, so it's not really necessary. If it didn't, > we would want to fix container_of().
Yep, container_of is more type safe than I thought. Mostly I was being paranoid about wanting to catch any mistakes I made when moving the FIP controller around. I can drop the macro to inline change here. _______________________________________________ devel mailing list [email protected] http://www.open-fcoe.org/mailman/listinfo/devel
