________________________________ From: James Smart [mailto:[email protected]] Sent: Thursday, July 09, 2009 11:52 AM To: Ma, Steve Cc: [email protected] Subject: Re: [Open-FCoE] [RESUBMIT PATCH] fcoe-utils: fcping implementation via FC pass-through interface
Yea Ma, Steve wrote: -----Original Message----- From: James Smart [mailto:[email protected]] Sent: Thursday, July 09, 2009 10:18 AM To: Ma, Steve Cc: [email protected]<mailto:[email protected]> Subject: Re: [Open-FCoE] [RESUBMIT PATCH] fcoe-utils: fcping implementation via FC pass-through interface This is cool. Brings out one comment in my mind though... It uses hbaapi to find the adapter, but then reverts to sg_io for the echo ELS. Seems odd and makes this very linux-centric. Why wouldn't we extend the hbaapi interface to have a generic send_els routine (it has a bunch of like functions, but they are specific to an ELS), and wrapper the els-sending in the library (which is very linux-centric in implementation) ? -- james Hi James, The HBAAPI spec (SNIA version) the vendor library based on does not have a generic ELS pass-through function entry; however, it has a generic CT pass-through function entry. This is why I do SG_IO in the fcping.c for ELS. I know this is really not convenient. Thanks for your comments. Steve Ma You confirmed what I said - but didn't answer - why wouldn't we add a generic ELS function to the library used by fcoe-utils ? Also seems like a great insulator if anything ever changed in the SGIO interface (like the protocol define, etc). -- james James, I think it is reasonable to add a generic ELS pass-though service function in HBAAPI. But I need to figure out what it will take to make that happen. I will need to discuss the issue with our team to get the estimate and priority. As far as I know, T11 takes the SNIA HBAAPI and created FC-HBA. The ELS service function should be added into FC-HBA. If possible, we could have a single function for both CT and ELS pass-through. What we need to do would be to switch our vendor library from SNIA hbaapi to T11 fc-hba, and we need to revise the FC-HBA spec CT pass-through function to one for CT and ELS. In the meantime, we need to add the ELS/CT pass-through service routine into our vendor library and then update the fcping code to make use of the new fc-hba function. Please advise anything I am missing. I will keep you updated for the progress. -- Steve Ma _______________________________________________ devel mailing list [email protected] http://www.open-fcoe.org/mailman/listinfo/devel
