On Wed, 2009-07-15 at 14:55 -0700, Joe Eykholt wrote:
> > @@ -273,17 +273,12 @@ static int fcoe_netdev_config(struct fc_lport
> *lp, struct net_device *netdev)
> > /* Setup lport private data to point to fcoe softc */
> > fc = lport_priv(lp);
> > fc->ctlr.lp = lp;
> > - fc->real_dev = netdev;
> > - fc->phys_dev = netdev;
> > -
> > - /* Require support for get_pauseparam ethtool op. */
> > - if (netdev->priv_flags & IFF_802_1Q_VLAN)
> > - fc->phys_dev = vlan_dev_real_dev(netdev);
> > + fc->netdev = netdev;
> >
> > /* Do not support for bonding device */
> > - if ((fc->real_dev->priv_flags & IFF_MASTER_ALB) ||
> > - (fc->real_dev->priv_flags & IFF_SLAVE_INACTIVE) ||
> > - (fc->real_dev->priv_flags & IFF_MASTER_8023AD)) {
> > + if ((fc->netdev->priv_flags & IFF_MASTER_ALB) ||
> > + (fc->netdev->priv_flags & IFF_SLAVE_INACTIVE) ||
> > + (fc->netdev->priv_flags & IFF_MASTER_8023AD)) {
>
> It'd be better to use the netdev variable instead of fc->netdev
> above as well as in other places below.
>
Done.
<snip>
>
> Looks good. I bet it conflicts with other pending patches by Chris,
I agree but should be easy to resolve as you also said below since
mostly it is just name change in this patch.
> but
> should be easy to resolve.
_______________________________________________
devel mailing list
[email protected]
http://www.open-fcoe.org/mailman/listinfo/devel
