These macros introduce extra undesirable semicolons that keep them from being used in expressions, and they don't protect against being passed an expression.
Add parens and remove the semicolons. Signed-off-by: Joe Eykholt <[email protected]> --- include/scsi/libfc.h | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/include/scsi/libfc.h b/include/scsi/libfc.h index d888cbe..2fdd8ac 100644 --- a/include/scsi/libfc.h +++ b/include/scsi/libfc.h @@ -223,9 +223,9 @@ struct fc_rport_libfc_priv { }; #define PRIV_TO_RPORT(x) \ - (struct fc_rport *)((void *)x - sizeof(struct fc_rport)); + ((struct fc_rport *)((void *)(x) - sizeof(struct fc_rport))) #define RPORT_TO_PRIV(x) \ - (struct fc_rport_libfc_priv *)((void *)x + sizeof(struct fc_rport)); + ((struct fc_rport_libfc_priv *)((void *)(x) + sizeof(struct fc_rport))) static inline void fc_rport_set_name(struct fc_rport *rport, u64 wwpn, u64 wwnn) { _______________________________________________ devel mailing list [email protected] http://www.open-fcoe.org/mailman/listinfo/devel
