On Mon, 2009-09-28 at 12:28 -0700, Robert Love wrote: > On Mon, 2009-09-21 at 10:53 -0700, Bhanu Prakash Gollapudi wrote: > > Incorporated Joe's review comments. > > > > Currently lport and rport event callbacks are part of rport_ops > > and are not exported to the LLDDs. This patch enables LLDDs to > > provide a driver specific callback routine which can be called > > when the remote port is ready. > > > > Signed-off-by: Bhanu Gollapudi <[email protected]> > > --- > > Hi Bhanu, > > I think this approach is fine assuming the user is a CNA and not a > netdev based Ethernet driver. If it's the prior then this change should > be fine as is, but should not be merged until there is a mainline user > for this functionality. If it's the latter then this code would be used > for an OOB communication mechanism between libfc and the driver. I'd > like to see some buy off from the netdev developers if that's the case > and I'd probably like to explore a more robust OOB communication > interface. > > Is there a mainline driver that will use these hooks? Is it a CNA / > multi-function device (storage) driver or an Ethernet driver? > > //Rob
Thanks for reviewing this Robert. The user is going to be a CNA. And, as you pointed out, there is no mainline user for this functionality yet. Will submit this change again when our driver is ready. -Bhanu > > > _______________________________________________ devel mailing list [email protected] http://www.open-fcoe.org/mailman/listinfo/devel
