On Thu, 2009-10-15 at 17:46 -0700, Vasu Dev wrote: > From: Mike Christie <[email protected]> > > This patch modifies scsi_host_tematepl->change_queue_depth so that > it takes an argument indicating why it is being called. This will be > used so that if a LLD needs to do some extra processing when > handling queue fulls or later ramp ups, it can do so. > > This is a simple port of the drivers setting a change_queue_depth > callback. In the patch I just have these LLDs adjust the queue depth > if the user was requesting it. > > Signed-off-by: Mike Christie <[email protected]> > > -v2 > Also converted pmcraid_change_queue_depth and then verified > all modules compile using "make allmodconfig" for any new build > warnings on X86_64. > > Updated original description after combing two original > patches from Mike to make this patch git bisectable. > > Signed-off-by: Vasu Dev <[email protected]>
This still doesn't build: drivers/scsi/53c700.c: In function 'NCR_700_detect': drivers/scsi/53c700.c:331: warning: assignment from incompatible pointer type drivers/scsi/53c700.c: At top level: drivers/scsi/53c700.c:2085: error: conflicting types for 'NCR_700_change_queue_depth' drivers/scsi/53c700.c:178: error: previous declaration of 'NCR_700_change_queue_depth' was here It looks like just an unconverted function prototype, so the patch below fixes it. James --- diff --git a/drivers/scsi/53c700.c b/drivers/scsi/53c700.c index a5a493d..6c60a80 100644 --- a/drivers/scsi/53c700.c +++ b/drivers/scsi/53c700.c @@ -175,7 +175,7 @@ STATIC void NCR_700_chip_reset(struct Scsi_Host *host); STATIC int NCR_700_slave_alloc(struct scsi_device *SDpnt); STATIC int NCR_700_slave_configure(struct scsi_device *SDpnt); STATIC void NCR_700_slave_destroy(struct scsi_device *SDpnt); -static int NCR_700_change_queue_depth(struct scsi_device *SDpnt, int depth); +static int NCR_700_change_queue_depth(struct scsi_device *SDpnt, int depth, int reason); static int NCR_700_change_queue_type(struct scsi_device *SDpnt, int depth); STATIC struct device_attribute *NCR_700_dev_attrs[]; _______________________________________________ devel mailing list [email protected] http://www.open-fcoe.org/mailman/listinfo/devel
