Hugh Daschbach wrote: > Both PLOGI and RTV response processing conditionally scale e_d_tov, > but use different scaling factors. The scaling factor is correct in > RTV response processing. Bring PLOGI e_d_tov scaling in line with RTV > common service parameter inspection. > > Signed-off-by: Hugh Daschbach <[email protected]> > --- > drivers/scsi/libfc/fc_rport.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/scsi/libfc/fc_rport.c b/drivers/scsi/libfc/fc_rport.c > index 0230052..97923bb 100644 > --- a/drivers/scsi/libfc/fc_rport.c > +++ b/drivers/scsi/libfc/fc_rport.c > @@ -623,7 +623,7 @@ static void fc_rport_plogi_resp(struct fc_seq *sp, struct > fc_frame *fp, > > tov = ntohl(plp->fl_csp.sp_e_d_tov); > if (ntohs(plp->fl_csp.sp_features) & FC_SP_FT_EDTR) > - tov /= 1000; > + tov /= 1000000; > if (tov > rdata->e_d_tov) > rdata->e_d_tov = tov; > csp_seq = ntohs(plp->fl_csp.sp_tot_seq);
Acked-by: Joe Eykholt <[email protected]> On reading the spec, it says that we should ignore the e_d_tov value in PLOGI responses except for in the point-to-point and local-loop cases, which we currently don't support. That's a separate problem. Joe _______________________________________________ devel mailing list [email protected] http://www.open-fcoe.org/mailman/listinfo/devel
