If built with debugging enabled (required a source code change and recompile), there was a debug message with bad arguments that would segfault.
Signed-off-by: Chris Leech <[email protected]> --- fipvlan.c | 12 ++++++------ 1 files changed, 6 insertions(+), 6 deletions(-) diff --git a/fipvlan.c b/fipvlan.c index 9179172..1f5556b 100644 --- a/fipvlan.c +++ b/fipvlan.c @@ -407,18 +407,18 @@ void create_missing_vlans() return; TAILQ_FOREACH(fcf, &fcfs, list_node) { - vlan = lookup_vlan(fcf->ifindex, fcf->vlan); - if (vlan) { - FIP_LOG_DBG("VLAN %s.%d already exists as %s", - fcf->ifindex, fcf->vlan, vlan->ifname); - continue; - } real_dev = lookup_iff(fcf->ifindex, NULL); if (!real_dev) { FIP_LOG_ERR(ENODEV, "lost device %d with discoved FCF?", fcf->ifindex); continue; } + vlan = lookup_vlan(fcf->ifindex, fcf->vlan); + if (vlan) { + FIP_LOG_DBG("VLAN %s.%d already exists as %s", + real_dev->ifname, fcf->vlan, vlan->ifname); + continue; + } snprintf(vlan_name, IFNAMSIZ, "%s.%d-fcoe", real_dev->ifname, fcf->vlan); rc = vlan_create(fcf->ifindex, fcf->vlan, vlan_name); _______________________________________________ devel mailing list [email protected] http://www.open-fcoe.org/mailman/listinfo/devel
