On 6/29/10 10:05 PM, Bhanu (Venkata Bhanu Prakash) Gollapudi wrote:
> In the lport state machine, looks like we are not retrying LS_RJT response 
> for FLOGI/SCR/NS commands.
Is there a specific reason for this, or did we miss this. For rport state 
machine, we do retry the LS_RJT.

It looks that way to me also.

We should retry after a delay.  It seems like we should change
the test at the beginning of fc_lport_error() that says:

        if (!fp || PTR_ERR(fp) == -FC_EX_TIMEOUT) {

to

        if (PTR_ERR(fp) != -FC_EX_CLOSED) {

Or, to reduce indentation it could be:

        if (PTR_ERR(fp) == -FC_EX_CLOSED)
                return;
        ...

I haven't tested this.

        Regards,
        Joe
_______________________________________________
devel mailing list
[email protected]
http://www.open-fcoe.org/mailman/listinfo/devel

Reply via email to