On Tue, Aug 24, 2010 at 04:14:41PM -0700, Joe Eykholt wrote: > On 8/24/10 2:51 PM, Chris Leech wrote: > > If the DCB_REQUIRED or AUTO_VLAN parameters are not set in the > > configuration file, treat them as YES by default instead of NO. > > Let's not change the default on people. It might create a surprise.
This came out of some existing confusion, over the fact that the template config file we ship says the default for both these settings is "yes". I'd be OK with just changing the text in the config file, but we should make them match. > > > Signed-off-by: Chris Leech <[email protected]> > > Tested-by: Ross Brattain <[email protected]> > > --- > > > > fcoemon.c | 12 ++++++++---- > > 1 files changed, 8 insertions(+), 4 deletions(-) > > > > diff --git a/fcoemon.c b/fcoemon.c > > index bf0de93..eea657f 100644 > > --- a/fcoemon.c > > +++ b/fcoemon.c > > @@ -368,8 +368,10 @@ static int fcm_read_config_files(void) > > free(next); > > continue; > > } > > - /* if not found, default to "no" */ > > - if (!strncasecmp(val, "yes", 3) && rc == 1) > > + /* if not found, default to "yes" */ > > + if (!strncasecmp(val, "no", 2) && rc == 1) > > + next->dcb_required = 0; > > + else > > next->dcb_required = 1; > > > > /* AUTO_VLAN */ > > @@ -381,8 +383,10 @@ static int fcm_read_config_files(void) > > free(next); > > continue; > > } > > - /* if not found, default to "no" */ > > - if (!strncasecmp(val, "yes", 3) && rc == 1) > > + /* if not found, default to "yes" */ > > + if (!strncasecmp(val, "no", 2) && rc == 1) > > + next->auto_vlan = 0; > > + else > > next->auto_vlan = 1; > > > > fclose(fp); > > > > _______________________________________________ > > devel mailing list > > [email protected] > > http://www.open-fcoe.org/mailman/listinfo/devel _______________________________________________ devel mailing list [email protected] http://www.open-fcoe.org/mailman/listinfo/devel
