On 8/31/10 1:14 PM, Nicholas A. Bellinger wrote:
> Hi Joe and Robert,
>
> So after jumping to v2.6.36-rc3 for the lio-core-2.6.git/lio-4.0 branch
> recently and fixing some minor breakage around the original struct
> fc4_prov patches I merged from Joe in the spring, mostly having to do
> with drivers/scsi/libfc/libfc_lport.c:fc_lport_recv_req() changes from
> this commit:
>
> [SCSI] libfc: don't require a local exchange for incomining requests
> http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=922611569572d3c1aa0ed6491d21583fb3fcca22
>
> I was able to get libfc + struct fc4_prov compiling after fixing the
> conflicts. However, I have run into non-trivial breakage in the
> Open-FCoE.org / TCM_FC fabric module itself because of it's dependence
> bit upon having direct access to the passed struct fc_seq. The code
> currently assigns to struct fc_seq * to struct ft_cmd->seq, and gets
> used in a number of subsequent areas after the struct fc4_prov->recv()
> entry hook at drivers/target/tcm_fc/tfc_cmd.c:ft_recv_cmd() gets called.
>
> I took a very brief look at trying to resolve the breakage myself, but
> quickly got a bit lost in terms of what TCM_FC actually needs to be
> accessing struct fc_seq directly for. Would either of you gentlemen
> mind giving me a bit of insight into what you think would be required by
> TCM_FC in order to function with the recent libfc fc_lport_recv_req()
> changes..?
I caused this problem, and anticipated that I would have
to make changes to tcm_fc to accommodate it. Then I forgot by the
time it made it upstream.
Now incoming requests don't get a sequence assigned unless they ask for
it, so we need to call lport->tt.seq_assign() for the request.
It turns out I forgot that that takes a reference on the sequence, so
I have another patch to add to drop the refcnt.
I can work on this at some point in the next few days if you can wait.
Joe
_______________________________________________
devel mailing list
[email protected]
http://www.open-fcoe.org/mailman/listinfo/devel
