On Mon, 2010-10-25 at 20:47 +0800, Hillf Danton wrote: > There seems frame should be freed against memory leakage. > > Signed-off-by: Hillf Danton <[email protected]> > --- > > --- a/drivers/scsi/libfc/fc_fcp.c 2010-09-13 07:07:38.000000000 +0800 > +++ b/drivers/scsi/libfc/fc_fcp.c 2010-10-25 20:33:58.000000000 +0800 > @@ -1685,6 +1685,7 @@ static void fc_fcp_srr_resp(struct fc_se > */ > if (fh->fh_type == FC_TYPE_BLS) { > fc_fcp_unlock_pkt(fsp); > + fc_frame_free(fp); > return; > }
My first thought was that we need to do a fc_fcp_pkt_release here since we're doing a fc_fcp_pkt_hold in fc_fcp_srr, but on further consideration I think this BLS check is unnecessary. fc_exch_recv checks for BLS frames before calling any of the response handlers. _______________________________________________ devel mailing list [email protected] http://www.open-fcoe.org/mailman/listinfo/devel
