> > > On 12/1/10 3:27 PM, Yi Zou wrote: > > In case there is an error in the received frame in fc_fcp_recv, it > should be > > freed. > > But IS_ERR indicates fp is not a frame, but an error code, so the > existing code is correct. > > Joe Yeah, you are right, pretty dumb that I completely missed that. This was an old patch sitting in my tree that it was seemingly fixing mem leak in one of of my tests when I was hitting fc_fcp_error()...
Thanks, yi > > > > > Signed-off-by: Yi Zou <[email protected]> > > --- > > > > drivers/scsi/libfc/fc_fcp.c | 2 +- > > 1 files changed, 1 insertions(+), 1 deletions(-) > > > > diff --git a/drivers/scsi/libfc/fc_fcp.c b/drivers/scsi/libfc/fc_fcp.c > > index 72013d4..434a4f4 100644 > > --- a/drivers/scsi/libfc/fc_fcp.c > > +++ b/drivers/scsi/libfc/fc_fcp.c > > @@ -747,7 +747,7 @@ static void fc_fcp_recv(struct fc_seq *seq, struct > fc_frame *fp, void *arg) > > > > if (IS_ERR(fp)) { > > fc_fcp_error(fsp, fp); > > - return; > > + goto out; > > } > > > > fh = fc_frame_header_get(fp); > > > > _______________________________________________ > > devel mailing list > > [email protected] > > http://www.open-fcoe.org/mailman/listinfo/devel _______________________________________________ devel mailing list [email protected] http://www.open-fcoe.org/mailman/listinfo/devel
