On Wed, 2011-05-04 at 10:35 -0700, Ritesh Raj Sarraf wrote:
> From: Ritesh Raj Sarraf <[email protected]>
>
> I'm not sure if the current makefile compiles as documented in INSTALL but I
> had to bring in these changes while packaging for Debian.
>
> Will it be possible to simplify the build?
>
> Signed-off-by: Ritesh Raj Sarraf <[email protected]>
> ---
> Makefile.am | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/Makefile.am b/Makefile.am
> index 704031d..e7cb5a2 100644
> --- a/Makefile.am
> +++ b/Makefile.am
> @@ -11,7 +11,7 @@ pkgconfig_DATA = HBAAPI.pc
> dist_sysconf_DATA = hba.conf
> dist_noinst_DATA = HBAAPILIB.c HBAAPI.pc.in libHBAAPI.spec hbaapi2.2.patch
>
> -hbaapilib.c: ${srcdir}/HBAAPILIB.c ${srcdir}/hbaapi2.2.patch
> +hbaapilib.c:
> cp ${srcdir}/HBAAPILIB.c $@
> patch $@ < ${srcdir}/hbaapi2.2.patch
>
Isn't this just saying that ${srcdir}/HBAAPILIB.c and
${srcdir}/hbaapi2.2.patch must exist before we can create hbaapilib.c?
In other words, the files we're about to use need to exist... I'm not
sure how removing the requisite HBAAPILIB.c and hbaapi2.2.patch files
would help.
hbaapi2.2.patch exists in hbaapi_build, so you should always have that
file. You only get HBAAPILIB.c by following this step from the
QUICKSTART:
2) Untar the tarball and move its contents to hbaapi_build/
and change into its directory
# tar -xvzf hbaapi_src_2.2.tgz
# mv hbaapi_src_2.2/* hbaapi_build/
# rmdir hbaapi_src_2.2/
# cd hbaapi_build/
It's the 'mv' that will place HBAAPILIB.c in ${srcdir} and should
satisfy the requirement.
I didn't dig into this too deeply so I could be wrong about something,
but I think this is how it's supposed to be working.
//Rob
_______________________________________________
devel mailing list
[email protected]
https://lists.open-fcoe.org/mailman/listinfo/devel
