On Mon, 2011-05-09 at 12:24 -0700, Yi Zou wrote: > Michał Mirosław's patch (http://patchwork.ozlabs.org/patch/94421/) fixes the > issue (http://patchwork.ozlabs.org/patch/94188/) about not populating FCoE > related > flags correctly on vlan devices. However, only NETIF_F_FCOE_CRC is part of the > NETIF_F_ALL_TX_OFFLOADS right now, where weed NETIF_F_FCOE_MTU and NETIF_F_FSO > as well. > > Therefore, add NETIF_F_ALL_FCOE to indicate feature flags used by FCoE TX > offloads. > These include NETIF_F_FCOE_CRC, NETIF_F_FCOE_MTU, and NETIF_F_FSO. They are > not part > of the NETIF_F_ALL_TX_OFFLOADS. This would eventually make sure all FCoE > needed > flags are populated properly to vlan devices. > > Signed-off-by: Yi Zou <[email protected]> > --- > > include/linux/netdevice.h | 6 +++++- > 1 files changed, 5 insertions(+), 1 deletions(-) > > diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h > index e7244ed..40b3df8 100644 > --- a/include/linux/netdevice.h > +++ b/include/linux/netdevice.h > @@ -1097,10 +1097,14 @@ struct net_device { > > #define NETIF_F_ALL_TSO (NETIF_F_TSO | NETIF_F_TSO6 | NETIF_F_TSO_ECN) > > +#define NETIF_F_ALL_FCOE (NETIF_F_FCOE_CRC | NETIF_F_FCOE_MTU | \ > + NETIF_F_UFO)
UFO? Surely FSO, like you wrote in the commit message... Ben. > #define NETIF_F_ALL_TX_OFFLOADS (NETIF_F_ALL_CSUM | NETIF_F_SG | \ > NETIF_F_FRAGLIST | NETIF_F_ALL_TSO | \ > NETIF_F_HIGHDMA | \ > - NETIF_F_SCTP_CSUM | NETIF_F_FCOE_CRC) > + NETIF_F_SCTP_CSUM | \ > + NETIF_F_ALL_FCOE) > > /* > * If one device supports one of these features, then enable them > > -- > To unsubscribe from this list: send the line "unsubscribe netdev" in > the body of a message to [email protected] > More majordomo info at http://vger.kernel.org/majordomo-info.html -- Ben Hutchings, Senior Software Engineer, Solarflare Not speaking for my employer; that's the marketing department's job. They asked us to note that Solarflare product names are trademarked. _______________________________________________ devel mailing list [email protected] https://lists.open-fcoe.org/mailman/listinfo/devel
