> -----Original Message-----
> From: Love, Robert W
> Sent: Wednesday, June 29, 2011 1:38 PM
> To: Parikh, Neerav; [email protected]
> Subject: RE: [Open-FCoE] [PATCH] hbaapi_build: Correct
> HBA_PORTSPEED_NOT_NEGOTIATED value in hbaapi.h
>
> >-----Original Message-----
> >From: [email protected] [mailto:[email protected]]
> >On Behalf Of Neerav Parikh
> >Sent: Friday, June 24, 2011 2:09 PM
> >To: [email protected]
> >Subject: [Open-FCoE] [PATCH] hbaapi_build: Correct
> >HBA_PORTSPEED_NOT_NEGOTIATED value in hbaapi.h
> >
> >From: Neerav Parikh <[email protected]>
> >
> >The HBA API Port Attributes like PortSpeed and PortSupportedSpeed
> >are expected to be bitmasks.
> >But, if for example a given port's supported speeds are 1 Gbit and
> >10 Gbit then the value for the PortSupportedSpeed comes out as "5"
> >that is currently being used for HBA_PORTSPEED_NOT_NEGOTIATED.
> >
> >As per the common HBA API Specification Phase 2 the value for the
> >HBA_PORTSPEED_NOT_NEGOTIATED is defined as 1<<15.
> >
> >This patch is to update the HBA_PORTSPEED_NOT_NEGOTIATED value as
> >per specification.
> >
> >Signed-off-by: Neerav Parikh <[email protected]>
> >Tested-by: Ross Brattain <[email protected]>
> >---
> > Makefile.am | 3 ++-
>
> What's up with these Makefile changes. I don't see that they're
> related to the change described above.
>
> If you actually care about these Makefile changes, please submit
> them in a different patch.
>
> Thanks, //Rob
The hbaapi2.2.patch file before this change only had changes for
HBAAPILIB.c file. But, with the current patch the hbaapi2.2.patch
file has changes for an additional file in the project.
Hence, had to make changes in Makefile to let the hbaapi2.2.patch
applied during build for all files instead of one and removed
while cleanup.
Let me know if this explains the changes and whether you want me
to split the Makefile changes into another patch.
Thanks,
Neerav
>
> > hbaapi2.2.patch | 8 ++++++++
> > 2 files changed, 10 insertions(+), 1 deletions(-)
> >
> >diff --git a/Makefile.am b/Makefile.am
> >index 704031d..e5ef066 100644
> >--- a/Makefile.am
> >+++ b/Makefile.am
> >@@ -12,10 +12,11 @@ dist_sysconf_DATA = hba.conf
> > dist_noinst_DATA = HBAAPILIB.c HBAAPI.pc.in libHBAAPI.spec
> >hbaapi2.2.patch
> >
> > hbaapilib.c: ${srcdir}/HBAAPILIB.c ${srcdir}/hbaapi2.2.patch
> >+ patch < hbaapi2.2.patch
> > cp ${srcdir}/HBAAPILIB.c $@
> >- patch $@ < ${srcdir}/hbaapi2.2.patch
> >
> > clean-local:
> >+ -patch -R -N -r - < hbaapi2.2.patch
> > -rm -f hbaapilib.c
> > -if [ ${abs_srcdir} != ${abs_builddir} ]; then \
> > rm -f hba.conf; \
> >
_______________________________________________
devel mailing list
[email protected]
https://lists.open-fcoe.org/mailman/listinfo/devel
