On 10/19/2011 11:18 AM, Vasu Dev wrote:
On Tue, 2011-10-18 at 23:23 -0700, Bhanu Prakash Gollapudi wrote:
- fcoe_update_src_mac(lport, mac);
+ /* pre-FIP */
+ if (is_zero_ether_addr(mac))
+ fcoe_ctlr_recv_flogi(fip, lport, fp);
Vasu, what is the reason for not checking the return value for this?
what scenario does this handle?
It was checked to skip calling fc_lport_flogi_resp() before returning
from here but we want that to be called on each response given now
fc_lport_flogi_resp() has code to handle all bad response frames and
then kick retry on receipt of bad frame, otherwise lport state machine
would get stuck due to bad response frame consumed here and no retry
from fc_lport_flogi_resp(), so bottom line we always have to call
fc_lport_flogi_resp() unconditionally.
Makes sense. Thanks.
Bhanu
Good question Bahnu, reflects that you really looked into code
thoroughly.Thanks.
Vasu
_______________________________________________
devel mailing list
devel@open-fcoe.org
https://lists.open-fcoe.org/mailman/listinfo/devel
