> On Oct 28, 2011, at 11:59 AM, Zou, Yi wrote:
>
> >> fcoemon does not support the CEE type of dcbx messages. On cards that
> >> support the CEE flavor of dcbx, we constantly see the warning when
> >> configuration changes. Convert it to a DBG message to unclutter the
> log.
> >>
> >> Signed-off-by: Nithin Nayak Sujir <nsu...@broadcom.com>
> >> ---
> >> fcoemon.c | 2 +-
> >> 1 files changed, 1 insertions(+), 1 deletions(-)
> >>
> >> diff --git a/fcoemon.c b/fcoemon.c
> >> index f01d761..fd8cd1e 100644
> >> --- a/fcoemon.c
> >> +++ b/fcoemon.c
> >> @@ -1385,7 +1385,7 @@ static void fcm_process_ieee_msg(struct nlmsghdr
> >> *nlh)
> >>
> >> d = (struct dcbmsg *)NLMSG_DATA(nlh);
> >> if (d->cmd != DCB_CMD_IEEE_GET && d->cmd != DCB_CMD_IEEE_SET) {
> >> - FCM_LOG("%s: Unexpected command type %d\n", __func__, d->cmd);
> >> + FCM_LOG_DBG("%s: Unexpected command type %d\n", __func__, d-
> >>> cmd);
> >> return;
> >> }
> >>
> > I guess this is ok, although I am not sure if later ieee mode is
> default,
> > you may want to see this w/o debug on.
>
> The real solution will be to have fcoemon use the new CEE multicast
> netlink messages instead of what it has traditionally done. Handling them
> will get rid of the message and allow a fair amount of code in fcoemon to
> go away if we can get rid of the old method.
>
> Until that is done, this is a perfectly reasonable change to silence the
> message.
>
> --
> Mark Rustad, LAN Access Division, Intel Corporation
>
Makes sense, thanks, Mark.
yi
_______________________________________________
devel mailing list
devel@open-fcoe.org
https://lists.open-fcoe.org/mailman/listinfo/devel
