On Fri, Dec 9, 2011 at 10:56 PM, Zou, Yi <yi....@intel.com> wrote: > You were in vn2vn mode, I assume? I did not see this in fabric mode, > Since it seems only in vn timeout would hold the ctrl lock and then > do the mac update. I don't think we need rtnl lock to be held for > fcoe_ctlr_link_up() in fcoe_create, don't remember why...but the race > seems still there from device notification call back that comes in > w/ rtnl lock held... > > alternatively, rtnl lock is needed for dev_uc/mc_add/del in fcoe.c, > for that sake, ctrl lock can be dropped for update_mac(), however > logically we should hold ctrl lock instead of rtnl for update_mac(), > but fcoe is using netdev uc/mc updating calls...
Yes, this occurred in vn2vn mode. All I had to do to trigger that call stack is: # modprobe fcoe # echo eth0 >/sys/module/libfcoe/parameters/create_vn2vn By the way, this also occurs with kernel version 3.0.12. I haven't checked any other kernel versions yet. Bart. _______________________________________________ devel mailing list devel@open-fcoe.org https://lists.open-fcoe.org/mailman/listinfo/devel
