On Wed, Feb 29, 2012 at 03:19:57PM -0800, Vasu Dev wrote: > On Mon, 2012-02-27 at 14:22 -0500, Neil Horman wrote: > > Since commit 853d3cbbe431571c3ae822c8f5df43acff344ded went in, we are > > guaranteed a clean division beteen fcoe code that runs in softirq context > > and > > code that runs in process context. This opens the door for us to implement > > some > > minor cleanups and optimizaions in each context. They're not large, but > > taken > > as a unit, appear to provide approximately a 0.4%-1% throughput increase. > > They > > are mostly spinlock cleanups (removing bh disables where no longer needed), > > but > > I've also included a change to fcoe_percpu_receive_thread that allows us to > > receive multiple fcoe frames without having to constantly drop and > > re-acquire > > the rx_list lock. > > All make sense. Just curious with throughput change details, can you > share more details such as what IO size and is it consistent across > multiple runs? > I just did some very rudimentary testing: time dd if=<fcoe block dev> of=/dev/null bs=512 count=1000000 I repeated that 100 times and averaged the system time (since this was all system code I was testing). Did that with and without this patch set and computed the speedup.
Best Neil > Thanks > Vasu > > _______________________________________________ devel mailing list devel@open-fcoe.org https://lists.open-fcoe.org/mailman/listinfo/devel
