On 06/01/2012 03:59 PM, Rustad, Mark D wrote: > Mike, > > On Jun 1, 2012, at 1:22 PM, Mike Christie wrote: > >>> Ah funny. I guess things got messed up in that thread. I do not think >>> everyone was talking about the same thing. In it, I was saying the >>> problem was in the driver being null >>> http://marc.info/?l=linux-usb&m=133407600206379&w=2 >>> I thought we added the null driver check in that patch for that case, >>> but did not handle scsi_cmd_to_driver's dereference. >>> >>> It does not make sense to me why we are doing a ** instead of just a >>> normal old pointer. Was >>> >>> sd.c: >>> gd->private_data = &sdkp->driver; >>> supposed to just be >>> gd->private_data = sdkp->driver; >> >> or just do >> >> gd->private_data = &sd_template; > > I'm sure I don't know.
I see why. Bad grepping on my first try. It is due to the container_of use in some ULDs. Yeah, that is too big a change to just fix this issue. _______________________________________________ devel mailing list devel@open-fcoe.org https://lists.open-fcoe.org/mailman/listinfo/devel
