>
> With certain FCFs, it may take a little longer than 2secs for DCBX to sync
> after the link is ready. fipvlan is retried for only upto 2 secs, causing the
> fipvlan to not discover FCFs if DCB sync is not complete. In boot-from-SAN
> scenario this is fatal. Increase the retries for upto 10 secs allowing fipvlan
> to succeed.
>
> Signed-off-by: Bhanu Prakash Gollapudi <bprak...@broadcom.com>
> ---
> fipvlan.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/fipvlan.c b/fipvlan.c
> index 74d69cb..0db2a8e 100644
> --- a/fipvlan.c
> +++ b/fipvlan.c
> @@ -55,6 +55,8 @@
> #define FIP_LOG_ERRNO(...) sa_log_err(errno, __func__, __VA_ARGS__)
> #define FIP_LOG_DBG(...) sa_log_debug(__VA_ARGS__)
>
> +#define MAX_VLAN_RETRIES 50
> +
> /* global configuration */
>
> struct {
> @@ -733,7 +735,8 @@ retry:
> recv_loop(200);
> TAILQ_FOREACH(iff, &interfaces, list_node)
> /* if we did not receive a response, retry */
> - if (iff->req_sent && !iff->resp_recv && retry_count++ < 10) {
> + if (iff->req_sent && !iff->resp_recv &&
> + retry_count++ < MAX_VLAN_RETRIES) {
> FIP_LOG_DBG("VLAN discovery RETRY [%d]",
> retry_count);
> goto retry;
> }
> --
Looks good to me.
yi
_______________________________________________
devel mailing list
devel@open-fcoe.org
https://lists.open-fcoe.org/mailman/listinfo/devel
