From: Vasu Dev <vasu....@intel.com>
This code block is not reachable as for auto vlan configured
interface block condition check will always fail and that
prevents executing retry code block.
This condition will always fail, !(p->fcoe_enable && p->auto_vlan)
-v2:
Also removed unused FCM_VLAN_DISC_MAX
Signed-off-by: Vasu Dev <vasu....@intel.com>
---
fcoemon.c | 11 -----------
1 file changed, 11 deletions(-)
diff --git a/fcoemon.c b/fcoemon.c
index 73939a4..6ed93ab 100644
--- a/fcoemon.c
+++ b/fcoemon.c
@@ -89,7 +89,6 @@
#define FCOE_DISABLE SYSFS_FCOE "/disable"
#define FCM_VLAN_DISC_TIMEOUT (1000 * 1000) /* 1 seconds */
-#define FCM_VLAN_DISC_MAX 10 /* stop after 10 attempts */
#define DEF_RX_BUF_SIZE 4096
@@ -2529,16 +2528,6 @@ void fcm_vlan_disc_timeout(void *arg)
FCM_LOG_DBG("%s: VLAN discovery TIMEOUT [%d]",
p->ifname, p->vlan_disc_count);
p->vlan_disc_count++;
- if (!(p->fcoe_enable && p->auto_vlan) &&
- (p->vlan_disc_count > FCM_VLAN_DISC_MAX)) {
- FCM_LOG("%s: VLAN discovery failed after %d attempts",
- p->ifname, FCM_VLAN_DISC_MAX);
- FCM_LOG("%s: disabling VLAN discovery, trying FCoE on %s",
- p->ifname, p->ifname);
- p->auto_vlan = 0;
- fcp_set_next_action(p, FCP_ACTIVATE_IF);
- return;
- }
fip_send_vlan_request(p->fip_socket, p->ifindex, p->mac);
sa_timer_set(&p->vlan_disc_timer, FCM_VLAN_DISC_TIMEOUT);
}
_______________________________________________
devel mailing list
devel@open-fcoe.org
https://lists.open-fcoe.org/mailman/listinfo/devel
