> [
> James,
>
> Not sure why you could not see the original v3 on the list as the block part
> was pulled ok by Jens. Anyway, I have diffsplitted the v3 and v4 below is
> the scsi_lib part only, hopefully this works for you, pls let me know. Below
> is directly applicable against the current upstream 3.6-rc7 tip.
>
> ]
>
> Resending as v4 for the change on scsi_lib part, where the corresponding block
> part is at commit 37d7b34. Threads related to this can be found at:
>
> http://marc.info/?l=linux-scsi&m=134830150821548&w=2
> http://comments.gmane.org/gmane.linux.scsi/73497
> http://www.open-fcoe.org/patchwork/patch/2436/
>
> Signed-off-by: Yi Zou <yi....@intel.com>
> Cc: www.Open-FCoE.org <devel@open-fcoe.org>
> Cc: Tomas Henzl <the...@redhat.com>
> Cc: <linux-s...@vger.kernel.org>
> Cc: Jens Axboe <ax...@kernel.dk>
James,
Can you please apply this patch? I have been just being updating this patch for
four versions over and over and it was acked long time ago that I don't even
remember how long already. I also resent as you requested a month ago again.
Thanks,
yi
> ---
>
> drivers/scsi/scsi_lib.c | 5 ++++-
> 1 files changed, 4 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/scsi/scsi_lib.c b/drivers/scsi/scsi_lib.c
> index faa790f..daa72ef 100644
> --- a/drivers/scsi/scsi_lib.c
> +++ b/drivers/scsi/scsi_lib.c
> @@ -20,6 +20,7 @@
> #include <linux/delay.h>
> #include <linux/hardirq.h>
> #include <linux/scatterlist.h>
> +#include <linux/ratelimit.h>
>
> #include <scsi/scsi.h>
> #include <scsi/scsi_cmnd.h>
> @@ -768,6 +769,8 @@ void scsi_io_completion(struct scsi_cmnd *cmd,
> unsigned int good_bytes)
> enum {ACTION_FAIL, ACTION_REPREP, ACTION_RETRY,
> ACTION_DELAYED_RETRY} action;
> char *description = NULL;
> + static DEFINE_RATELIMIT_STATE(rs, DEFAULT_RATELIMIT_INTERVAL,
> + DEFAULT_RATELIMIT_BURST);
>
> if (result) {
> sense_valid = scsi_command_normalize_sense(cmd, &sshdr);
> @@ -961,7 +964,7 @@ void scsi_io_completion(struct scsi_cmnd *cmd,
> unsigned int good_bytes)
> case ACTION_FAIL:
> /* Give up and fail the remainder of the request */
> scsi_release_buffers(cmd);
> - if (!(req->cmd_flags & REQ_QUIET)) {
> + if (!(req->cmd_flags & REQ_QUIET) && __ratelimit(&rs)) {
> if (description)
> scmd_printk(KERN_INFO, cmd, "%s\n",
> description);
_______________________________________________
devel mailing list
devel@open-fcoe.org
https://lists.open-fcoe.org/mailman/listinfo/devel
