Hi guys,
These changes were committed on CVS.
Thanks to Juha's patch, we can easyly keep backward compatibility after
removing the UserName RADIUS avp by having a new pseudo variable which
works exactly the same as former UserName. The pv is $Au(accounting
username) item that gets username the same way as accounting module was
doing - try to get it first from credentials and if not present, use the
FROM URI.
regards,
bogdan
Bogdan-Andrei Iancu wrote:
Any other opinions on this? let us close the discussion and go for the
coding.
Just to summarize:
1) remove UserName RADIUS attribute from RADIUS accounting;
Pros: it will be aligned with SQL and SYSLOG which do not log
this value
minimal changes: in most of the cases, as SIP ID is
the same as AUTH ID,
logging FROM will be the same
more flexibility in billing information - in most of
the cases the billing ID is not
the UserName value
less unnecessary stuff to be logged if not really
required
Contras: it may require some extra config in some cases
2) remove Cseq, FROM URI, TO URI also - they are not dialog
relevant and also from
billing point of view -> log less data and if really
required are easy to add via
extra accounting.
regards,
bogdan
Juha Heinanen wrote:
Bogdan-Andrei Iancu writes:
> IMHO this proofs that that value might not be so essentialy after >
all....It might be accounted for two reasons:
> 1) dialog matching but is not the case here
> 2) billing purpose - in this case the requirements are very
various, > so I do not thing we can get to common behaviour. so there
are no 99% of > the case where it is used as it appears only in RADIUS.
i agree with this, but i have already stated my opinion. any other
opinions than bogdan, dan, and me? if not, dan looses 2 to 1 :-)
-- juha
_______________________________________________
Devel mailing list
[email protected]
http://openser.org/cgi-bin/mailman/listinfo/devel
_______________________________________________
Devel mailing list
[email protected]
http://openser.org/cgi-bin/mailman/listinfo/devel
