sounds useful to openser too
regards
klaus
-------- Original Message --------
Subject: [Serdev] [Patch] Access to freed memory in resolve.c
Date: Wed, 29 Nov 2006 11:31:20 +0100
From: Jan Andres <[EMAIL PROTECTED]>
Organization: freenet Cityline GmbH
To: [EMAIL PROTECTED]
Hi,
The function free_rdata_list() in CVS HEAD's resolve.c iterates through
a linked list of "struct rdata *", accessing each element's "next"
pointer after that element has already been freed. Here's the fix:
--- resolve.c.orig 2006-11-29 11:01:56.000000000 +0100
+++ resolve.c 2006-11-28 17:23:33.000000000 +0100
@@ -366,11 +366,13 @@
/* frees completely a struct rdata list */
void free_rdata_list(struct rdata* head)
{
- struct rdata* l;
- for(l=head; l; l=l->next){
+ struct rdata* l = head;
+ while (l != 0) {
+ struct rdata* next_l = l->next;
/* free the parsed rdata*/
if (l->rdata) local_free(l->rdata);
local_free(l);
+ l = next_l;
}
}
Regards,
Jan
--
Jan Andres <[EMAIL PROTECTED]>
VoIP Systems Engineer phone: +49 431 9020-557
freenet Cityline GmbH, Hamburger Chaussee 2-4, D-24114 Kiel, Germany
---------------------------------------------------------------------
"Object-oriented programming is an exceptionally bad idea which could
only have originated in California." -- E. W. Dijkstra
_______________________________________________
Serdev mailing list
[EMAIL PROTECTED]
http://lists.iptel.org/mailman/listinfo/serdev
--
Klaus Darilion
nic.at
_______________________________________________
Devel mailing list
[email protected]
http://openser.org/cgi-bin/mailman/listinfo/devel
