Patches item #1706639, was opened at 2007-04-24 14:02 Message generated for change (Comment added) made by codestrom You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=743022&aid=1706639&group_id=139143
Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None Status: Open Resolution: None Priority: 5 Private: No Submitted By: codestrom (codestrom) Assigned to: Nobody/Anonymous (nobody) Summary: postgres module Makefile patch Initial Comment: This is a trivial patch that corrects the postgres Makefile detection for the include, libsdir and libs cflags. This patch uses the standard way to detect the location of these files and cflags. Please test and report back. ---------------------------------------------------------------------- >Comment By: codestrom (codestrom) Date: 2007-05-17 17:23 Message: Logged In: YES user_id=1777411 Originator: YES >From my experience pg_config comes with postgres by default and is on ever dist I've ever worked with. (Just to double check I asked in #postgresql) There are a couple of potential caveats to this.. 1) The unusual case where pg_config isn't in the path.. 2) pg_config isn't correct.. (gentoo misconfigured system, but this is a user problem) In the past for autoconf and friends I'll usually add another option to define where pg_config is located, but should I just put that in the Makefile in this case? Thanks Christopher ---------------------------------------------------------------------- Comment By: Bogdan (bogdan_iancu) Date: 2007-05-04 18:12 Message: Logged In: YES user_id=1275325 Originator: NO Hi, I'm not a postgres user, but is pg_config provided all the time with the client libs? I want to be sure your solution will work in all cases. What about a 2 stage solution - use pg_config if present and if not, fallback to the current predefined paths. regards, bogdan ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=743022&aid=1706639&group_id=139143 _______________________________________________ Devel mailing list Devel@openser.org http://openser.org/cgi-bin/mailman/listinfo/devel