Patches item #1742425, was opened at 2007-06-24 14:05 Message generated for change (Comment added) made by henningw You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=743022&aid=1742425&group_id=139143
Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: modules Group: ver devel Status: Open Resolution: None Priority: 5 Private: No Submitted By: Victor Gamov (vitspec) Assigned to: Nobody/Anonymous (nobody) Summary: try to use fetch_result only in MySQL module Initial Comment: This patch changes db_mysql_store_result() to db_mysql_fetch_result() calls. Both of them do the same works but fetch_result is more smart while store_result calls many subfunctions. This patch affected on SELECT queries only. This patch tested in config where some standard (like is_domain_local()) and some nonstandard SELECT queries used. Everything works is OK but test it more times please Thanks! ---------------------------------------------------------------------- Comment By: Henning Westerholt (henningw) Date: 2007-07-18 16:12 Message: Logged In: YES user_id=337916 Originator: NO Hello Victor. I did a review of the postgresql implementation of fetch_result, and they did the right thing: if the number of rows is zero, don't return anything. This makes much more sense as the mysql behavior. I changed the mysql driver to do it the same way. This is in my opinion also the right thing from the API point of view. Unfortunally i think your patch don't work anymore with this change, as it relied on the zero behavior. Cheers, Henning ---------------------------------------------------------------------- Comment By: Victor Gamov (vitspec) Date: 2007-07-11 19:00 Message: Logged In: YES user_id=1625470 Originator: YES Hi Henning! Is this patch approved now? We use it in our 1.2.1 release working in small installation and there is no problem with it. ---------------------------------------------------------------------- Comment By: Victor Gamov (vitspec) Date: 2007-06-24 14:28 Message: Logged In: YES user_id=1625470 Originator: YES After this patch will be tested then new pacth to remove all unused functions will be prepared ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=743022&aid=1742425&group_id=139143 _______________________________________________ Devel mailing list Devel@openser.org http://openser.org/cgi-bin/mailman/listinfo/devel
