On Tue, 30 Oct 2007 21:42:41 +0900 (JST)
[EMAIL PROTECTED] (YAMAMOTO Takashi) wrote:
> > > > + if (active && !(pc->flags & PAGE_CGROUP_FLAG_ACTIVE))
> > > > + direction = 1; /*from inactive to acvive */
> > > > + if (!active && (pc->flags & PAGE_CGROUP_FLAG_ACTIVE))
> > > > + direction = -1;
> > > > +
> > > > + if (direction) {
> > > > + struct mem_cgroup_zonestat *zstat =
> > > > &pc->mem_cgroup->zonestat;
> > > > + int index = page_cgroup_to_zonestat_index(pc);
> > > > + preempt_disable();
> > > > + __mem_cgroup_zonestat_add(zstat,
> > > > MEM_CGROUP_ZONESTAT_ACTIVE,
> > > > + direction, index);
> > > > + __mem_cgroup_zonestat_add(zstat,
> > > > MEM_CGROUP_ZONESTAT_INACTIVE,
> > > > + direction, index);
> > >
> > > dec?
> > >
> > direction(add value) is 1 or -1 here. Hmm, this is maybe confusing.
> > ok, I'll clean up this.
>
> adding the same value to both of active and inactive seems wrong.
> i think you want to subtract 'direction' from inactive here.
>
Ahh, ok, thanks. will fix.
-Kame
_______________________________________________
Containers mailing list
[EMAIL PROTECTED]
https://lists.linux-foundation.org/mailman/listinfo/containers
_______________________________________________
Devel mailing list
[email protected]
https://openvz.org/mailman/listinfo/devel
