On Wed, 2008-03-26 at 11:32 +0800, Herbert Xu wrote: > On Tue, Mar 25, 2008 at 06:40:00PM +0300, Pavel Emelyanov wrote: > > Commit 8b7817f3a959ed99d7443afc12f78a7e1fcc2063 ([IPSEC]: Add ICMP host > > relookup support) introduced some dst leaks on error paths: the rt > > pointer can be forgotten to be put. Fix it bu going to a proper label. > > > > Found after net namespace's lo refused to unregister :) Many thanks to > > Den for valuable help during debugging. > > > > Signed-off-by: Pavel Emelyanov <[EMAIL PROTECTED]> > > Signed-off-by: Denis V. Lunev <[EMAIL PROTECTED]> > > Thanks for catching this! > > > diff --git a/net/ipv4/icmp.c b/net/ipv4/icmp.c > > index ff9a8e6..db231cb 100644 > > --- a/net/ipv4/icmp.c > > +++ b/net/ipv4/icmp.c > > @@ -594,11 +594,11 @@ void icmp_send(struct sk_buff *skb_in, int type, int > > code, __be32 info) > > rt = NULL; > > break; > > default: > > - goto out_unlock; > > + goto ende; > > } > > I'm not sure about this bit though because xfrm_lookup is meant > to free the route on error.
This is not a problem, it assigns NULL in this case to a pointer. _______________________________________________ Devel mailing list [email protected] https://openvz.org/mailman/listinfo/devel
