Quoting [EMAIL PROTECTED] ([EMAIL PROTECTED]): > From: Sukadev Bhattiprolu <[EMAIL PROTECTED]> > Subject: [PATCH]: Propagate error code from devpts_pty_new > > Have ptmx_open() propagate any error code returned by devpts_pty_new() > (which returns either 0 or -ENOMEM anyway). > > Signed-off-by: Sukadev Bhattiprolu <[EMAIL PROTECTED]>
Seems nice and non-contentuous. Acked-by: Serge Hallyn <[EMAIL PROTECTED]> thanks, -serge > --- > drivers/char/tty_io.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > Index: 2.6.25-rc8-mm2/drivers/char/tty_io.c > =================================================================== > --- 2.6.25-rc8-mm2.orig/drivers/char/tty_io.c 2008-04-16 09:38:23.000000000 > -0700 > +++ 2.6.25-rc8-mm2/drivers/char/tty_io.c 2008-04-16 09:51:11.000000000 > -0700 > @@ -2835,8 +2835,8 @@ static int ptmx_open(struct inode *inode > filp->private_data = tty; > file_move(filp, &tty->tty_files); > > - retval = -ENOMEM; > - if (devpts_pty_new(tty->link)) > + retval = devpts_pty_new(tty->link); > + if (retval) > goto out1; > > check_tty_count(tty, "tty_open"); _______________________________________________ Containers mailing list [EMAIL PROTECTED] https://lists.linux-foundation.org/mailman/listinfo/containers _______________________________________________ Devel mailing list [email protected] https://openvz.org/mailman/listinfo/devel
