> +void context_release(struct cpt_context *ctx)
> +{
> +     ctx->ctx_state = CPT_CTX_ERROR;
> +
> +     if (ctx->file)
> +             fput(ctx->file);
> +     kfree(ctx);
> +}
> +
> +static void context_put(struct cpt_context *ctx)
> +{
> +     if (!--ctx->refcount)
> +             context_release(ctx);
> +}
> +
>  static int checkpoint(pid_t pid, int fd, unsigned long flags)
>  {
> -     return -ENOSYS; 
> +     struct file *file;
> +     struct cpt_context *ctx;
> +     int err;
> +
> +     err = -EBADF;
> +     file = fget(fd);
> +     if (!file)
> +             goto out;
> +
> +     err = -ENOMEM;
> +     ctx = context_alloc();
> +     if (!ctx)
> +             goto out_file;
> +
> +     ctx->file = file;
> +     ctx->ctx_state = CPT_CTX_DUMPING;
> +
> +     /* checkpoint */
> +     err = -ENOSYS;
> +
> +     context_put(ctx);
> +
> +out_file:
> +     fput(file);
> +out:
> +     return err; 
>  }

it looks like fput(file) is done twice in checkpoint() and context_release() ?

C.
_______________________________________________
Containers mailing list
[EMAIL PROTECTED]
https://lists.linux-foundation.org/mailman/listinfo/containers

_______________________________________________
Devel mailing list
Devel@openvz.org
https://openvz.org/mailman/listinfo/devel

Reply via email to