OL> As it is, it simplifies the code. However, how can we be certain OL> that grafting a dead socket doesn't break any assumptions OL> elsewhere ? For instance, unix_sock_destructor() will spit a OL> warning if it finds sk-> sk_socket != NULL. There may be other places (per protocol ?).
I think that in most cases the grafted struct socket is short-lived and therefore shouldn't be a problem with something like the destructor. I definitely prefer assuming we have an sk->sk_socket elsewhere and will be happy to remove the other checks, unless there's a compelling reason not to. -- Dan Smith IBM Linux Technology Center email: [email protected] _______________________________________________ Containers mailing list [email protected] https://lists.linux-foundation.org/mailman/listinfo/containers _______________________________________________ Devel mailing list [email protected] https://openvz.org/mailman/listinfo/devel
